Malevich Discussions Rss Feed

New Post: Any plans to update Malevich?

gregsohl — Fri, 03 May 2013 20:57:49 GMT

This is an interesting looking tool. I've been searching a bit for an ASP.NET based code review tool. This is one of the few with any degree of completeness.

Are there any plans to update it, for example, .NET version, VS 2012, support for Git, etc?

Thanks for sharing with the community!

Greg

New Post: Error installing Malevich on SQL SERVER 2008 R2

jalfx — Mon, 07 May 2012 18:09:53 GMT

It´s works, thanks!

But now i get another error. Any tips? Something about 'CodeReviewUser' and 'NT AUTHORITY
\Authenticated Users' not found..

System.Data.SqlClient.SqlException: Usuário ou grupo do Windows NT 'NT AUTHORITY
\Authenticated Users' não encontrado. Verifique o nome novamente.
Usuário ou grupo do Windows NT 'NT AUTHORITY\Authenticated Users' não encontrado
. Verifique o nome novamente.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Não é possível 'localizar' o usuário 'CodeReviewUser', pois ele não existe ou vo
cê não tem permissão.
Contexto do banco de dados alterado para 'master'.
Contexto do banco de dados alterado para 'CodeReview'.
   em System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolea
n breakConnection)
   em System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObj
ect stateObj)
   em System.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cm
dHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, Tds
ParserStateObject stateObj)
   em System.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName,
Boolean async)
   em System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(DbAsyncResult res
ult, String methodName, Boolean sendToPipe)
   em System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   em Installer.Program.InstallDatabase(InstallParameters installParams)
Could not deploy the database.
Press any key to exit...

New Post: Error installing Malevich on SQL SERVER 2008 R2

SergeySolyanik — Mon, 07 May 2012 16:51:03 GMT

You'd have to edit the deployment script and remove ALTER DATABASE lines that contain SQL_Latin1_General_CP1_CI_AS (do findstr in the directory which contains the installation files).

New Post: Error installing Malevich on SQL SERVER 2008 R2

jalfx — Mon, 07 May 2012 14:32:20 GMT

Any news about this issue? How can i tweak this scripts?

New Post: Review status

nkgenghis — Fri, 02 Mar 2012 09:14:44 GMT

I tried the review close shelfsetname.

But it prompts that "No active change in database." and refused the close operation.

So I don't know how to change the status.

New Post: Does Malevich support separate Web Server and DB Server

nkgenghis — Fri, 24 Feb 2012 08:52:35 GMT

Now, I tried to separate the Web Server and DB Server but failed.

In the DB part, it shows the Review History as the machine name of Web Server.

Is there any method to support it? Thanks a lot in advance!

New Post: Comment categorization

GingerBuffalo — Wed, 22 Feb 2012 23:27:19 GMT

Regarding commenting: I see your point. I think within our team, the friction to select a category from a drop-down wouldn't really be that much friction as to inhibit review activity. But I get that your aspiration is a complete minimum of resistance. The tool definitely does a very good job of that!

Regarding dev contributions: It might be a while before I have time to contribute, but would definitely be interested. I've never contributed to a CodePlex effort before (kind of selfishly, I've just been a consumer. :-) ), what\how would I need to do to get up to speed with the current state of your work on it, and what do I need to do to be a contributor?

New Post: Ability to restrict permissions within Malevich

GingerBuffalo — Wed, 22 Feb 2012 23:23:17 GMT

Thanks for the tip. I've tried out your partitioning feature. It worked very easily. Only problem really is that I can see this is just hiding the code reviews; I'm sure if given a URL, any member of one team can still view the other team's partition.

But anyway, you have already pointe this out in your suggestion to have separate Malevich databases. I think this is probably what we'll end up doing.

New Post: Comment categorization

SergeySolyanik — Wed, 22 Feb 2012 21:22:43 GMT

The philosophy of Malevich was always to make commenting as simple as possible. My fear was always that if you add categorization, you would introduce an extra click or two, and this would mean that some comments would not be entered :-).

WRT development - I am sitting on a massive chaange list that needs to be cleaned up - this is the current tip of the source - but just did not have time to do it. If you'd like to help, I would definitely appreciate it, and would be more than happy to do code reviews, etc.

New Post: Ability to restrict permissions within Malevich

SergeySolyanik — Wed, 22 Feb 2012 21:18:22 GMT

Actually, hiding code review activities is not tricky at all. Take a look here: http://malevich.codeplex.com/wikipage?title=Hosting%20multiple%20Malevich%20projects%20on%20the%20same%20box&referringTitle=Home

Now, if you wanted to ristrict the teams using security controls, THAT would be hard - the easiest thing is just have separate Malevich databases. You can then go to SQL, change log-in from "authenticated users" to a security group, and have participants join the security group.

New Post: Ability to restrict permissions within Malevich

GingerBuffalo — Wed, 22 Feb 2012 21:10:14 GMT

This might be beyond reasonable scope for a volunteer effort, but have you had any thought into implementing code review permissions within Malevich? For example, where you have a number of different teams of participating, and you don't really want\need different teams to see review activity of other teams, it doesn't seem to be possible within Malevich to limit access as such.

Or is there already a way to do this that I'm missing?

New Post: Comment categorization

GingerBuffalo — Wed, 22 Feb 2012 21:07:47 GMT

Do you have any plans to enable reviewers to classify comment categories? My team have been using Malevich now for a few months, and one of the things we've noticed is that it can get easy to lose track of Must Fix comments, from ones that are more question or suggestion orientated. We've made a practice of marking our comments as such (with tags like [Must Fix], [Question] etc.), but it would obviously be a great feature if Malevich provided the ability via something like a drop-down marker.

By the way: what's the state of Malevich v.next development? Do you have a group of active contributors? I might be interested to help in my occasional spare time if it would be of assistance.

New Post: Ability to modify e-mail notification workflow

SergeySolyanik — Tue, 20 Dec 2011 06:53:27 GMT

Hi,

Unfortunately, there is not configurable way to disable the follow-up email :-(. The web site calls the same storage procedure as review.exe to add a person to review. That storage procedure causes the email to be sent. You could change the source and recompile it, unfortunately, you would have to change at least the database and the web site (for example, clone AddReviewer SP to AddReviewerNoInvite, and then call it from Default.aspx.cs's AddToReviewers routine.

One other possible solution would be to change the email template to make it account for this scenario.

Sorry for the functionality problem. I plan to restart working on Malevich qiote soon and will add this as an option.

New Post: Ability to modify e-mail notification workflow

GingerBuffalo — Sat, 17 Dec 2011 00:18:10 GMT

My team have a mail-enabled security group we intend to target all of our reviews to. We would like to target all new reviews to this group, and allow any available participants for a given review to either ignore or participate in the review.

I have noticed that in this scenario, when using the --invite flag for this distribution list, that the mail that is generated contains a link to the "makemereviewer" url. This is good, as it is easy for participants to understand that by clicking through on this URL they are agreeing to participate as a voting reviewer. There is one minor, yet confusing behavior in the way Malevich handles this workflow though. After a reviewer clicks on the "makemereviewer" url, and agrees to be a reviewer, Malevich then sends out another e-mail to the reviewer that has accepted. It looks to me like the first e-mail (presenting the "makemereviewer" url) is of the Invite.html template; and the follow-up mail is of the Request.html template.

Truthfully, the follow-up mail is a little confusing to us. And if it were possible, we would probably choose to disable it. Is it possible to disable it via config file, or any other easily configurable method? We could always modify the Request.html template, to be a little less redundant and more clear in its language. But I thought I'd see if it were possible to turn it off altogether.

New Post: How to prevent display of /t whitespace characters in code reviews

GingerBuffalo — Thu, 17 Nov 2011 21:35:40 GMT

Yep. I just discovered this setting myself in web.config a few moments before your reply.

I also take your point about why you default this way (many people follow a practice prohibiting tabs...). It's worth considering.

Thanks for the quick responses!

New Post: How to prevent display of /t whitespace characters in code reviews

SergeySolyanik — Thu, 17 Nov 2011 21:32:41 GMT

Yes of course there is a way :-). Take a look at spacesPerTab property in web.config. It is -1 by default (show tabs) because majority of people prohibit tabs in their code and this setting makes stray tabs very visible. But if you do allow them, it's supported as well.

New Post: How to prevent display of /t whitespace characters in code reviews

GingerBuffalo — Thu, 17 Nov 2011 21:00:45 GMT

In my configuration of Malevich I've noticed that as code files are displayed in the browser, all of the \t tab characters present in sources to be reviewed are being presented on the screen. For example:

t\tfor (UINT uIndex = 0; uIndex < 4; uIndex++)
533 \t\t{ 616 \t\t{
534 \t\t\tif ((uIndex == 0 && !(uTaskStatus & TASKINDEX_SESSIONLOCK)) || 617 \t\t\tif ((uIndex == 0 && !(uTaskStatus & TASKINDEX_SESSIONLOCK)) ||
535 \t\t\t\t(uIndex == 1 && !(uTaskStatus & TASKINDEX_SESSIONUNLOCK)) || 618 \t\t\t\t(uIndex == 1 && !(uTaskStatus & TASKINDEX_SESSIONUNLOCK)) ||
536 \t\t\t\t(uIndex == 2 && !(uTaskStatus & TASKINDEX_REMOTECONNECT)) || 619 \t\t\t\t(uIndex == 2 && !(uTaskStatus & TASKINDEX_REMOTECONNECT)) ||
537 \t\t\t\t(uIndex == 3 && !(uTaskStatus & TASKINDEX_REMOTEDISCONNECT))) 620 \t\t\t\t(uIndex == 3 && !(uTaskStatus & TASKINDEX_REMOTEDISCONNECT)))
538 \t\t\t{ 621 \t\t\t{
539 \t\t\t\t_stprintf_s(szTaskXMLName, _countof(szTaskXMLName), 622 \t\t\t\t_stprintf_s(szTaskXMLName, _countof(szTaskXMLName),
540 \t\t\t\t\t_T("%s%s.XML"), 623 \t\t\t\t\t_T("%s%s.XML"),
541 \t\t\t\t\tpszAltXMLPath ? pszAltXMLPath : USERDOMAINNETLOGONPATH, szTaskNameList[uIndex]); 624 \t\t\t\t\tpszAltXMLPath ? pszAltXMLPath : USERDOMAINNETLOGONPATH, szTaskNameList[uIndex]);

This kind of kills readability for performing code reviews. In looking through the screenshots on this project, I don't see this behavior in the examples. So I'm guessing this isn't normal. Is there a setting or configuration I should investigate to correct this behavior?

New Post: How does TfsInterface Workspace member initialize when TFSDIFFSOURCE set to shelf?

SergeySolyanik — Mon, 31 Oct 2011 23:46:23 GMT

No, the old version of review.exe won't work with the new server. Upgrading (in this case, downgrading) is really straightforward though - just run the Malevich installer (MSI is just a shell, all the work is done by the installer exe that MSI installs on your desktop), and it will perform the downgrade.

New Post: How does TfsInterface Workspace member initialize when TFSDIFFSOURCE set to shelf?

GingerBuffalo — Mon, 31 Oct 2011 23:43:36 GMT

I see.

So, I've already gone through the steps to compile Malevich and deploy from source to configure the server (i.e. webUI, SQL, etc.). Do you think I can continue with this, and just use the binary distribution for review.exe, and reviewnotifier.exe?

Or do you have warnings about the stability of everything from source, WebUI, DB, and client pieces?

Thanks for the quick reply!

New Post: How does TfsInterface Workspace member initialize when TFSDIFFSOURCE set to shelf?

SergeySolyanik — Mon, 31 Oct 2011 23:40:00 GMT

Are you trying to compile Malevich from the source? If so, I would recommend using the binary distribution instead. The current source "tip" has not yet been fully debugged, and it went through a significant modification. The binary is extremely stable.